[BUG] subworkflow timeout propagation

[pvditt]

Tracking issue

#4087
#4765

Why are the changes needed?

• When a subworkflow's task fails due to reaching node-active-deadline, the workflow does not fail. The workflow continues to run after the timed out task gets aborted and getting set to "UNKNOWN" state

• When a task time's out due to reaching node-active-deadline, the task's status gets set to "UNKNOWN"

What changes were proposed in this pull request?

• Have subworkflows handle TimedOut state

• Transform EPhaseTimedout -> NodeExecution_TIMED_OUT when creating node execution events

How was this patch tested?

Ran a couple workflows. Would be a decent effort to add unit testing - can add if needed.

Setup process

Test subworkflow timeout propagation (will hit node-active-deadline on retry)

@task(
    timeout=timedelta(seconds=10),
    retries=1,
)
def demo_task():
    time.sleep(3000)



@task
def demo_task_1():
    time.sleep(3000)


@workflow
def subworkflow():
    demo_task()
    demo_task_1()


@workflow
def demo_workflow():
    subworkflow()

To isolate test to persisting aborted node on TimeOut:

Set node-active-deadline to small value in Flyte config:

propeller:
    node-config:
        default-deadlines:
            node-active-deadline: 10s

@task(
   retries=1,
)
def demo_task():
   time.sleep(3000)


@workflow
def demo_workflow():
   demo_task()

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[codecov]

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (73b1d40) 58.21% compared to head (f011b15) 58.20%.
Report is 5 commits behind head on master.

Files	Patch %	Lines
...er/pkg/controller/nodes/subworkflow/subworkflow.go	0.00%	16 Missing ⚠️
...lytepropeller/pkg/controller/nodes/transformers.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4766      +/-   ##
==========================================
- Coverage   58.21%   58.20%   -0.01%     
==========================================
  Files         626      626              
  Lines       53855    53911      +56     
==========================================
+ Hits        31349    31377      +28     
- Misses      19996    20023      +27     
- Partials     2510     2511       +1     

Flag	Coverage Δ
unittests	58.20% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.