[Docs] Fix toctree links to User Guide, Environment Setup, and Contributing sections #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibuting landing pages Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4781 +/- ##
==========================================
- Coverage 58.54% 58.52% -0.02%
==========================================
Files 625 625
Lines 53669 53669
==========================================
- Hits 31418 31411 -7
- Misses 19734 19741 +7
Partials 2517 2517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:S
added 3 commits
January 25, 2024 17:33
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:L
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:M
|
I don't understand the codecov test failure, but it looks like my change fixes the toctree issue. |
Future-Outlier
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fixes docs build error introduced by #4548. The toctree links in introduction.md need to point to flytesnacks/{filename} for the user guide, environment setup, and contributing sections.
What changes were proposed in this pull request?
Fixes toctree links in introduction.md
Check all the applicable boxes
Related PRs
#4548
Docs link
https://flyte--4781.org.readthedocs.build/en/4781/introduction.html