Add notes to selfAuth with Azure docs #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidmirror-ops <david [email protected]>
dosubot
bot
added
size:S
davidmirror-ops
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4835 +/- ##
==========================================
+ Coverage 58.98% 59.68% +0.70%
==========================================
Files 567 645 +78
Lines 44496 49534 +5038
==========================================
+ Hits 26244 29563 +3319
- Misses 15858 17396 +1538
- Partials 2394 2575 +181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
reviewed
Feb 7, 2024
|
|
||
| 11. Restart ``flytescheduler``` to start using authenticated requests: | ||
| 10. Verify that the `flytepropeller`, `flytescheduler` and `flyteadmin` Pods are restarted and Running: |
There was a problem hiding this comment.
What's the reason to remove the instructions on how to restart the deployments (kubectl rollout restart ...) in the docs?
There was a problem hiding this comment.
Because once the Helm release is upgraded, it triggers redeployment of those services
neverett
previously approved these changes
Feb 7, 2024
|
|
||
| .. prompt:: bash $ | ||
| For `multi-cluster deployments <https://docs.flyte.org/en/latest/deployment/deployment/multicluster.html>`__, this secret definition has to be added to the `values-dataplane.yaml` file. |
There was a problem hiding this comment.
Suggested change
| For `multi-cluster deployments <https://docs.flyte.org/en/latest/deployment/deployment/multicluster.html>`__, this secret definition has to be added to the `values-dataplane.yaml` file. | |
| For `multi-cluster deployments <https://docs.flyte.org/en/latest/deployment/deployment/multicluster.html>`__ running `flytepropeller` in the control plane cluster, you must add this secret definition to the `values-dataplane.yaml` file. |
There was a problem hiding this comment.
I'm trying not to get lost in grammar :) The idea is: in every cluster where propeller is running you need that secret (not only environments where propeller is running on the control plane cluster).
Propeller in the control plane cluster is optional, for the data plane is a must.
Let me know if it's clear or not
There was a problem hiding this comment.
Gotcha, then I would suggest:
For `multi-cluster deployments <https://docs.flyte.org/en/latest/deployment/deployment/multicluster.html>`__, you must add this secret definition to the `values-dataplane.yaml` file.
|
|
||
| .. prompt:: bash $ | ||
| For `multi-cluster deployments <https://docs.flyte.org/en/latest/deployment/deployment/multicluster.html>`__, this secret definition has to be added to the `values-dataplane.yaml` file. | ||
| There's no need to create this secret in the control plane cluster if you're not running `flytepropeller` there. |
There was a problem hiding this comment.
Suggested change
| There's no need to create this secret in the control plane cluster if you're not running `flytepropeller` there. | |
| If you are not running `flytepropeller` in the control plane cluster, you do not need to create this secret there. |
Signed-off-by: davidmirror-ops <david [email protected]>
Signed-off-by: davidmirror-ops <david [email protected]>
neverett
approved these changes
Feb 8, 2024
katrogan
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add notes from recent Azure deployments Signed-off-by: davidmirror-ops <david [email protected]> * Rephrase multicluster auth Signed-off-by: davidmirror-ops <david [email protected]> * Rephrase multicluster auth v2 Signed-off-by: davidmirror-ops <david [email protected]> --------- Signed-off-by: davidmirror-ops <david [email protected]> Co-authored-by: davidmirror-ops <david [email protected]> Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
* Add notes from recent Azure deployments Signed-off-by: davidmirror-ops <david [email protected]> * Rephrase multicluster auth Signed-off-by: davidmirror-ops <david [email protected]> * Rephrase multicluster auth v2 Signed-off-by: davidmirror-ops <david [email protected]> --------- Signed-off-by: davidmirror-ops <david [email protected]> Co-authored-by: davidmirror-ops <david [email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
From recent interactions with Flyte deployments with Azure as IdP, some precisions are needed in the selfAuth docs.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link