Fix asterisk in cron table being rendered as list item #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2024 15:58
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:L
neverett
commented
Feb 5, 2024
| @@ -95,6 +176,7 @@ Below is an example with duration in `days`. | |||
|
|
|||
| ) | |||
|
|
|||
| .. _rate_unit: | |||
|
|
|||
| Rate Unit | |||
There was a problem hiding this comment.
This is outside the scope of this PR, but I don't understand the difference between this section and the "Fixed rate schedules" section above.
neverett
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
- Coverage 58.98% 58.48% -0.50%
==========================================
Files 567 567
Lines 44496 50533 +6037
==========================================
+ Hits 26244 29555 +3311
- Misses 15858 18584 +2726
Partials 2394 2394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ppiegaze
approved these changes
Feb 9, 2024
katrogan
pushed a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: nikki everett <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: nikki everett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The asterisks in the cron table in the Schedules doc are rendering as list items instead of asterisks.
What changes were proposed in this pull request?
Simply escaping the asterisk didn't work, since it's in a table, so I turned the rst table into an HTML table and that seemed to fix the issue.
Check all the applicable boxes
Docs link
https://flyte--4836.org.readthedocs.build/en/4836/concepts/schedules.html