[FLYTE-486] Support selecting IDP based on the query parameter #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
pmahindrakar-oss
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4838 +/- ##
==========================================
- Coverage 58.97% 58.96% -0.02%
==========================================
Files 644 644
Lines 55146 55160 +14
==========================================
Hits 32525 32525
- Misses 20048 20059 +11
- Partials 2573 2576 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
katrogan
previously approved these changes
Feb 6, 2024
katrogan
previously approved these changes
Feb 6, 2024
katrogan
approved these changes
Feb 6, 2024
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss
force-pushed
the
add-idp-param-flyte
branch
from
28e6f53 to
6b617c9
Compare
pingsutw
approved these changes
Feb 6, 2024
pmahindrakar-oss
added a commit
that referenced
this pull request
May 1, 2024
#61) * Added config option for IDPQuery parameter --------- Signed-off-by: pmahindrakar-oss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test Plan
Tested on internal dogfood tenant and verified without the google tab in the login screen we can login using the okta apps in the dashboard page
Rollout Plan (if applicable)
Rollout to cloud and serverless-gcp
Jira Issue
https://unionai.atlassian.net/browse/
Checklist