Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align dir structure and URL structure with left nav hierarchy #4843

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

ppiegaze
Copy link
Member

@ppiegaze ppiegaze commented Feb 6, 2024

Why are the changes needed?

We want to align the directory structure in flyte/docs and the URL structure with the hierarchy of the left nav.

This will make adding and re-organizing content more straightforward

@ppiegaze ppiegaze requested a review from neverett February 6, 2024 11:37
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 6, 2024
@ppiegaze ppiegaze changed the title Peeter/docs/align dir structure with left nav Align dir structure and URL structure with left nav hierarchy Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4223a83) 58.98% compared to head (843bf79) 59.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4843      +/-   ##
==========================================
+ Coverage   58.98%   59.03%   +0.04%     
==========================================
  Files         644      644              
  Lines       55146    54786     -360     
==========================================
- Hits        32529    32343     -186     
+ Misses      20043    19869     -174     
  Partials     2574     2574              
Flag Coverage Δ
unittests 59.07% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2024
@ppiegaze ppiegaze merged commit 7abb38a into master Feb 6, 2024
49 checks passed
@ppiegaze ppiegaze deleted the peeter/docs/align-dir-structure-with-left-nav branch February 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants