Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MANIFEST.in for flyteidl #4850

Merged

Conversation

thomasjpfan
Copy link
Member

This PR adds a MANIFEST.in for flyteidl so that the sdist only includes the necessary files.

Signed-off-by: Thomas J. Fan <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Feb 7, 2024
@thomasjpfan thomasjpfan changed the title Adds MANIFEST.in Adds MANIFEST.in for flyteidl Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a087802) 58.97% compared to head (58f9be8) 58.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4850   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         645      645           
  Lines       55162    55162           
=======================================
  Hits        32533    32533           
  Misses      20054    20054           
  Partials     2575     2575           
Flag Coverage Δ
unittests 58.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2024
@eapolinario eapolinario merged commit 9a9e8a3 into flyteorg:master Feb 7, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants