Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add link to hosted sandbox #4856

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Re-add link to hosted sandbox #4856

merged 1 commit into from
Feb 9, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Feb 7, 2024

What changes were proposed in this pull request?

Re-adds the link to the hosted sandbox so users can try Flyte in the browser.

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

https://flyte--4856.org.readthedocs.build/en/4856/quickstart_guide.html

Signed-off-by: nikki everett <[email protected]>
@neverett neverett requested a review from ppiegaze February 7, 2024 19:58
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a9e8a3) 58.97% compared to head (3db1f7e) 58.97%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4856   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         645      645           
  Lines       55162    55162           
=======================================
  Hits        32533    32533           
  Misses      20054    20054           
  Partials     2575     2575           
Flag Coverage Δ
unittests 58.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett self-assigned this Feb 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 9, 2024
@neverett neverett merged commit c06f5eb into master Feb 9, 2024
49 checks passed
@neverett neverett deleted the docs/readd-sandbox-link branch February 9, 2024 17:04
katrogan pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants