Verify unbounded inputs for all scheduled launch plan types #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: Katrina Rogan <[email protected]>
dosubot
bot
added
size:S
squiishyy
approved these changes
Feb 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4867 +/- ##
==========================================
+ Coverage 58.97% 59.63% +0.65%
==========================================
Files 645 567 -78
Lines 55162 41239 -13923
==========================================
- Hits 32533 24593 -7940
+ Misses 20054 14251 -5803
+ Partials 2575 2395 -180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pmahindrakar-oss
approved these changes
Feb 8, 2024
katrogan
added a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
closes #4866
Why are the changes needed?
See tracking issue, launch plan registration and validation should catch unbounded inputs before schedule invocation
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link