Replaced deprecated bitnami/bitnami-shell image with bitnami/os-shell #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamal Eybov <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4882 +/- ##
==========================================
- Coverage 59.51% 58.98% -0.54%
==========================================
Files 645 645
Lines 51891 55162 +3271
==========================================
+ Hits 30883 32535 +1652
- Misses 18435 20051 +1616
- Partials 2573 2576 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
katrogan
pushed a commit
that referenced
this pull request
Feb 20, 2024
#4882) Signed-off-by: Kamal Eybov <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
flyteorg#4882) Signed-off-by: Kamal Eybov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Docker repository
bitnami/bitnami-shellhas been deprecated for a while and was removed recently. Single binary builds fail due to that (failed workflow example).bitnami/os-shellis a direct replacement.What changes were proposed in this pull request?
This change updates deprecated image references with the new one.
How was this patch tested?
Singe binary workflow was executed successfully with these changes applied.
Setup process
N/A.
Screenshots
N/A.
Check all the applicable boxes