-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readability for ingress.yaml under charts/flyte-core/templates/common #4945
Open
lowc1012
wants to merge
6
commits into
flyteorg:master
Choose a base branch
from
lowc1012:flyte-issues-4944
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Feb 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4945 +/- ##
=======================================
Coverage 58.99% 59.00%
=======================================
Files 645 645
Lines 55542 55548 +6
=======================================
+ Hits 32769 32775 +6
Misses 20182 20182
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Mar 4, 2024
lowc1012
force-pushed
the
flyte-issues-4944
branch
from
March 4, 2024 11:19
97d62b8
to
97e6112
Compare
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
lowc1012
force-pushed
the
flyte-issues-4944
branch
from
March 7, 2024 10:56
97e6112
to
20f59d0
Compare
ddl-ebrown
reviewed
Mar 9, 2024
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4944
Why are the changes needed?
Because charts/flyte-core/templates/common/ingress.yaml looks messy, it need to be improved for readability
What changes were proposed in this pull request?
grpcRoutes
template to _helpers.tplHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link