Time partition granularity #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
force-pushed
the
time-partition-granularity
branch
from
989f70c to
a45d97d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
- Coverage 58.98% 58.96% -0.02%
==========================================
Files 645 645
Lines 55559 55562 +3
==========================================
- Hits 32770 32761 -9
- Misses 20195 20206 +11
- Partials 2594 2595 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
andrewwdye
reviewed
Mar 5, 2024
| @@ -20,18 +20,38 @@ message ArtifactKey { | |||
| message ArtifactBindingData { | |||
| // These two fields are only relevant in the partition value case | |||
| oneof partition_data { | |||
| string partition_key = 2; | |||
| bool bind_to_time_partition = 3; | |||
| string partition_key = 1; | |||
There was a problem hiding this comment.
yeah, we're dropping all tables on this one.
wild-endeavor
previously approved these changes
Mar 5, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Mar 5, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
Adding granularity enum to time partition for ID
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link