Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying flyte pod webhook deployment resources #4988

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Allow specifying flyte pod webhook deployment resources #4988

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
934f449
Allow specifying flyte pod webhook deployment resources
katrogan Mar 1, 2024
1d8dac8
revert
katrogan Mar 1, 2024
edc091b
Comments, add resources
katrogan Mar 1, 2024
478e254
rm limits
katrogan Mar 1, 2024
3279ad5
Merge branch 'master' of github.com:flyteorg/flyte into webhook-resou…
pingsutw Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/flyte-core/templates/propeller/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
{{- if .Values.webhook.resources -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Not important in this case but we could also do the following.

{{- with .Values.webhook.resources }}
resources: {{- toYaml . | nindent 12 }}
{{- end }}

This is not really that important as it's just syntactic difference, only really benefits for more complex config. We can always update later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mhotan updated to address both your comments, although having a hard time reasoning about what sensible defaults would be here esp given the recent ephemeral storage incident. figure it might be safer to err on overprovisioning for now

resources: {{- toYaml .Values.webhook.resources | nindent 12 }}
{{- end }}
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
Loading