Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying flyte pod webhook deployment resources #4988

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Allow specifying flyte pod webhook deployment resources #4988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
934f449
Allow specifying flyte pod webhook deployment resources
katrogan Mar 1, 2024
1d8dac8
revert
katrogan Mar 1, 2024
edc091b
Comments, add resources
katrogan Mar 1, 2024
478e254
rm limits
katrogan Mar 1, 2024
3279ad5
Merge branch 'master' of github.com:flyteorg/flyte into webhook-resou…
pingsutw Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/flyte-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,9 @@ helm install gateway bitnami/contour -n flyte
| storage.s3.secretKey | string | `""` | AWS IAM user secret access key to use for S3 bucket auth, only used if authType is set to accesskey |
| storage.type | string | `"sandbox"` | Sets the storage type. Supported values are sandbox, s3, gcs and custom. |
| webhook.enabled | bool | `true` | enable or disable secrets webhook |
| webhook.resources.requests.cpu | string | `"200m"` | |
| webhook.resources.requests.ephemeral-storage | string | `"500Mi"` | |
| webhook.resources.requests.memory | string | `"500Mi"` | |
| webhook.securityContext | object | `{"fsGroup":65534,"fsGroupChangePolicy":"Always","runAsNonRoot":true,"runAsUser":1001,"seLinuxOptions":{"type":"spc_t"}}` | Sets securityContext for webhook pod(s). |
| webhook.service | object | `{"annotations":{"projectcontour.io/upstream-protocol.h2c":"grpc"},"type":"ClusterIP"}` | Service settings for the webhook |
| webhook.serviceAccount | object | `{"annotations":{},"create":true,"imagePullSecrets":[]}` | Configuration for service accounts for the webhook |
Expand Down
3 changes: 3 additions & 0 deletions charts/flyte-core/templates/propeller/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
{{- with .Values.webhook.resources }}
resources: {{- toYaml . | nindent 12 }}
{{- end }}
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
6 changes: 6 additions & 0 deletions charts/flyte-core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,12 @@ webhook:
seLinuxOptions:
type: spc_t

resources:
requests:
cpu: 200m
ephemeral-storage: 500Mi
memory: 500Mi

# ------------------------------------------------
#
# COMMON SETTINGS
Expand Down
5 changes: 5 additions & 0 deletions deployment/eks/flyte_aws_scheduler_helm_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,6 +1411,11 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
resources:
requests:
cpu: 200m
ephemeral-storage: 500Mi
memory: 500Mi
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
5 changes: 5 additions & 0 deletions deployment/eks/flyte_helm_dataplane_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,11 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
resources:
requests:
cpu: 200m
ephemeral-storage: 500Mi
memory: 500Mi
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
5 changes: 5 additions & 0 deletions deployment/eks/flyte_helm_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,6 +1541,11 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
resources:
requests:
cpu: 200m
ephemeral-storage: 500Mi
memory: 500Mi
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
5 changes: 5 additions & 0 deletions deployment/gcp/flyte_helm_dataplane_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,11 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
resources:
requests:
cpu: 200m
ephemeral-storage: 500Mi
memory: 500Mi
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
5 changes: 5 additions & 0 deletions deployment/gcp/flyte_helm_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,6 +1563,11 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
resources:
requests:
cpu: 200m
ephemeral-storage: 500Mi
memory: 500Mi
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
5 changes: 5 additions & 0 deletions deployment/sandbox/flyte_helm_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7306,6 +7306,11 @@ spec:
allowPrivilegeEscalation: false
capabilities:
drop: ["ALL"]
resources:
requests:
cpu: 200m
ephemeral-storage: 500Mi
memory: 500Mi
volumeMounts:
- name: config-volume
mountPath: /etc/flyte/config
Expand Down
Loading