-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set flyteadmin grpc port correctly in config / Flyte-core flyteadmin / datacatalog expose ports #5013
Merged
davidmirror-ops
merged 1 commit into
flyteorg:master
from
ddl-ebrown:set-containerports
Mar 27, 2024
Merged
Set flyteadmin grpc port correctly in config / Flyte-core flyteadmin / datacatalog expose ports #5013
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ flyteadmin: | |
- configMap: | ||
name: sslcerts # name of the ca-certificates.crt configmap in the cluster | ||
name: sslcerts | ||
additionalVolumeMounts: | ||
additionalVolumeMounts: | ||
- mountPath: /etc/ssl/certs/ # where to mount the above certificate | ||
name: sslcerts | ||
# -- Appends extra command line arguments to the serve command | ||
|
@@ -459,11 +459,11 @@ configmap: | |
console: | ||
BASE_URL: /console | ||
CONFIG_DIR: /etc/flyte/config | ||
|
||
logger: | ||
show-source: true | ||
level: 6 | ||
|
||
# -- Domains configuration for Flyte projects. This enables the specified number of domains across all projects in Flyte. | ||
domain: | ||
domains: | ||
|
@@ -485,7 +485,8 @@ configmap: | |
# Refer to the [server config](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/config#ServerConfig). | ||
server: | ||
httpPort: 8088 | ||
grpcPort: 8089 | ||
grpc: | ||
port: 8089 | ||
security: | ||
# -- Controls whether to serve requests over SSL/TLS. | ||
secure: false | ||
|
@@ -552,7 +553,7 @@ configmap: | |
- profile | ||
- openid | ||
- offline_access | ||
clientId: <clientid declared in IDP for the UI access> | ||
clientId: <clientid declared in IDP for the UI access> | ||
|
||
# -- Datacatalog server config | ||
datacatalogServer: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -626,7 +626,8 @@ configmap: | |
# Refer to the [server config](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/config#ServerConfig). | ||
server: | ||
httpPort: 8088 | ||
grpcPort: 8089 | ||
grpc: | ||
port: 8089 | ||
security: | ||
# -- Controls whether to serve requests over SSL/TLS. | ||
secure: false | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -377,7 +377,8 @@ flyte: | |
# Refer to the [server config](https://pkg.go.dev/github.com/lyft/[email protected]/pkg/config#ServerConfig). | ||
server: | ||
httpPort: 8088 | ||
grpcPort: 8089 | ||
grpc: | ||
port: 8089 | ||
security: | ||
# -- Controls whether to serve requests over SSL/TLS. | ||
secure: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -293,7 +293,8 @@ data: | |
server.yaml: | | ||
server: | ||
httpPort: 8088 | ||
grpcPort: 8089 | ||
grpc: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure how this file is regenerated, so edited by hand |
||
port: 8089 | ||
security: | ||
# Controls whether to serve requests over SSL/TLS. | ||
secure: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This corresponds to https://github.com/flyteorg/flyte/blob/master/flyteadmin/pkg/config/config.go#L24