Fix minio config on helpers.tpl

[davidmirror-ops]

Tracking issue

Closes #5004

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Deployed to an on-prem K8s cluster with minio and it successfully executes workflows.

I used storage.type: sandbox

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly. (It will be part of the Flyte the Hard Way repo.)
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (fd42f65) to head (b4cb968).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5018   +/-   ##
=======================================
  Coverage   58.99%   59.00%           
=======================================
  Files         645      645           
  Lines       55542    55542           
=======================================
+ Hits        32769    32770    +1     
+ Misses      20182    20181    -1     
  Partials     2591     2591           

Flag	Coverage Δ
unittests	59.00% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

This was put in place initially to accommodate fast registration in the legacy sandbox. In the demo cluster (i.e. the current sandbox) we override that value separately.

We're in the process of removing the legacy sandbox, so I'm wondering if we shouldn't go through the effort of setting up a separate helm chart for the on-prem scenario. Not for this PR obviously.

[davidmirror-ops]

@eapolinario I've considered a chart for on-prem too. The problem is that it'd be hard to design it following Helm conventions, especially considering how many options are available to achieve the same thing in the on prem world. For example, what default values to set for Ingress? for what controller? Also, what if someone is not using minio? (they can go with custom, which is not greatly documented but that's a different problem).
So, I'd rather try to make our two main charts more flexible.