Flyte-core remove unnecessary ingress capability checks #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Kubernetes 1.19 was released in August 2020 and it added support for non-beta ingress types - Kubernetes 1.22 removed the beta ingress type in August 2021 and went out of support in October 2022 - As of March 2024, only Kubernetes 1.26 and later are supported - Therefore, there's no reason to make this check! Signed-off-by: ddl-ebrown <[email protected]>
dosubot
bot
added
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5028 +/- ##
==========================================
+ Coverage 58.98% 59.00% +0.02%
==========================================
Files 645 645
Lines 55548 55548
==========================================
+ Hits 32764 32776 +12
+ Misses 20193 20181 -12
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Mar 11, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
- Kubernetes 1.19 was released in August 2020 and it added support for non-beta ingress types - Kubernetes 1.22 removed the beta ingress type in August 2021 and went out of support in October 2022 - As of March 2024, only Kubernetes 1.26 and later are supported - Therefore, there's no reason to make this check! Signed-off-by: ddl-ebrown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
Kubernetes 1.19 was released in August 2020 and it moved ingress out of beta
Kubernetes 1.22 removed the beta ingress type in August 2021 and went out of support in October 2022
As of March 2024, only Kubernetes 1.26 and later are supported
Therefore, there's no reason to make this check!
What changes were proposed in this pull request?
Simplify ingress code
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link