[Housekeeping] Bump Go version to 1.22 #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5032 +/- ##
===========================================
- Coverage 61.00% 35.82% -25.19%
===========================================
Files 794 1299 +505
Lines 51441 109297 +57856
===========================================
+ Hits 31384 39159 +7775
- Misses 17165 66032 +48867
- Partials 2892 4106 +1214
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lowc1012
force-pushed
the
flyte-issues-4994
branch
from
804d40f to
23c77cf
Compare
lowc1012
changed the title
lowc1012
force-pushed
the
flyte-issues-4994
branch
from
88540c7 to
cc19bab
Compare
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
lowc1012
force-pushed
the
flyte-issues-4994
branch
from
cc19bab to
53fec8b
Compare
dosubot
bot
added
size:M
lowc1012
changed the title
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
dosubot
bot
added
size:L
ddl-ebrown
suggested changes
Mar 28, 2024
|
@lowc1012 , are you still going to work on this PR? If so, can you merge master? |
Signed-off-by: WenChih Lo <[email protected]>
|
@eapolinario |
* go mod tidy for flytectl/go.mod Signed-off-by: Ryan Lo <[email protected]>
lowc1012
force-pushed
the
flyte-issues-4994
branch
from
2322980 to
0f3c597
Compare
|
@lowc1012 , building the sandbox is hitting a failure, can you take a look? You can reproduce locally by running |
Signed-off-by: Ryan Lo <[email protected]>
|
@eapolinario thanks, I push a new commit |
Signed-off-by: Ryan Lo <[email protected]>
pingsutw
previously approved these changes
Jun 26, 2024
eapolinario
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Thank you, this is looking pretty good. Can you also update https://github.com/flyteorg/flyte/blob/master/boilerplate/flyte/golang_support_tools/go.mod#L3 ?
Signed-off-by: Ryan Lo <[email protected]>
lowc1012
force-pushed
the
flyte-issues-4994
branch
from
5a8f5ac to
6ae0746
Compare
@eapolinario done |
pingsutw
approved these changes
Jul 19, 2024
eapolinario
approved these changes
Jul 22, 2024
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
* update go 1.22 & make go-tidy Signed-off-by: Ryan Lo <[email protected]> * update Dockerfiles Signed-off-by: Ryan Lo <[email protected]> * update gha workflows Signed-off-by: Ryan Lo <[email protected]> * upgrade x tools to fix panic crash in go 1.22 Signed-off-by: Ryan Lo <[email protected]> * go mod tidy Signed-off-by: Ryan Lo <[email protected]> * update gha workflows Signed-off-by: Ryan Lo <[email protected]> * (flytestdlib) go mod tidy Signed-off-by: Ryan Lo <[email protected]> * trigger tests Signed-off-by: Ryan Lo <[email protected]> * * bump arduino/setup-protoc to v3 * go mod tidy for flytectl/go.mod Signed-off-by: Ryan Lo <[email protected]> * update go version for sandbox-bundled Signed-off-by: Ryan Lo <[email protected]> * chore Signed-off-by: Ryan Lo <[email protected]> * update boilerplate/flyte/golang_support_tools/go.mod Signed-off-by: Ryan Lo <[email protected]> --------- Signed-off-by: Ryan Lo <[email protected]> Signed-off-by: WenChih Lo <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
ddl-ebrown
added a commit
to dominodatalab/flyte
that referenced
this pull request
Sep 4, 2024
- flyteorg#5032 updated builds to use Go 1.22 -- but in practice it looks like flytectl is being built with an outdated toolchain based on Go 1.22.0 instead of Go 1.22.5 or 1.22.6 (i.e. latest) For instance, flytectl v0.9.0 reports being built with Go 1.22.0 ❯ go version -m -v flytectl flytectl: go1.22.0 Ensure the proper Go environment for security reasons
ddl-ebrown
added a commit
to dominodatalab/flyte
that referenced
this pull request
Sep 4, 2024
- flyteorg#5032 updated builds to use Go 1.22 -- but in practice it looks like flytectl is being built with an outdated toolchain based on Go 1.22.0 instead of Go 1.22.5 or 1.22.6 (i.e. latest) For instance, flytectl v0.9.0 reports being built with Go 1.22.0 ❯ go version -m -v flytectl flytectl: go1.22.0 Ensure the proper Go environment for security reasons Signed-off-by: ddl-ebrown <[email protected]>
3 tasks
ddl-ebrown
added a commit
to dominodatalab/flyte
that referenced
this pull request
Sep 4, 2024
- flyteorg#5032 updated builds to use Go 1.22 -- but in practice it looks like flytectl is being built with an outdated toolchain based on Go 1.22.0 instead of Go 1.22.5 or 1.22.6 (i.e. latest) See https://go.dev/doc/toolchain for further details For instance, flytectl v0.9.0 reports being built with Go 1.22.0 ❯ go version -m -v flytectl flytectl: go1.22.0 Ensure the proper Go environment for security reasons Signed-off-by: ddl-ebrown <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 10, 2024
- #5032 updated builds to use Go 1.22 -- but in practice it looks like flytectl is being built with an outdated toolchain based on Go 1.22.0 instead of Go 1.22.5 or 1.22.6 (i.e. latest) See https://go.dev/doc/toolchain for further details For instance, flytectl v0.9.0 reports being built with Go 1.22.0 ❯ go version -m -v flytectl flytectl: go1.22.0 Ensure the proper Go environment for security reasons Signed-off-by: ddl-ebrown <[email protected]>
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Sep 12, 2024
- flyteorg#5032 updated builds to use Go 1.22 -- but in practice it looks like flytectl is being built with an outdated toolchain based on Go 1.22.0 instead of Go 1.22.5 or 1.22.6 (i.e. latest) See https://go.dev/doc/toolchain for further details For instance, flytectl v0.9.0 reports being built with Go 1.22.0 ❯ go version -m -v flytectl flytectl: go1.22.0 Ensure the proper Go environment for security reasons Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4994
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link