Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building read-the-docs for flyteidl #5120

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

We no longer build the read-the-docs flyteidl site separately. That's handled by the monodocs build. We keep getting alerts due to old dependencies in the flyteidl docs requirements files.

What changes were proposed in this pull request?

This PR removes the mentions to doc-requirements.txt in flyteidl.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (cb6384a) to head (10e749c).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5120      +/-   ##
==========================================
+ Coverage   58.49%   59.00%   +0.50%     
==========================================
  Files         627      645      +18     
  Lines       54155    55672    +1517     
==========================================
+ Hits        31680    32850    +1170     
- Misses      19942    20226     +284     
- Partials     2533     2596      +63     
Flag Coverage Δ
unittests 59.00% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario added the security Issues related to Security improvements label Mar 26, 2024
@eapolinario eapolinario merged commit 2842e5d into master Mar 26, 2024
48 checks passed
@eapolinario eapolinario deleted the dependabot-54--flyteidl-doc-requirements branch March 26, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation housekeeping Issues that help maintain flyte and keep it tech-debt free security Issues related to Security improvements size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant