Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add retries and backoffs for propeller sending events to admin #5166

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Apr 3, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

Propeller does not have retries or backoffs for the eventsink adminclient (but does for datacatalog and cacheservice). Instead on failure it will consume a system retry and retry (near immediately) to process the workflow, continuing to hammer admin.

What changes were proposed in this pull request?

  • add retries to sending events to admin from propeller + add exponential backoff
  • add config to make this configurable

How was this patch tested?

  • ran locally w/ admin down to ensure backoffs were being respected.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.79%. Comparing base (524b473) to head (cc3522d).
Report is 28 commits behind head on master.

❗ Current head cc3522d differs from pull request most recent head 5ba76af. Consider uploading reports for the commit 5ba76af to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5166       +/-   ##
===========================================
- Coverage   59.10%   17.79%   -41.31%     
===========================================
  Files         645        3      -642     
  Lines       55574      399    -55175     
===========================================
- Hits        32846       71    -32775     
+ Misses      20135      315    -19820     
+ Partials     2593       13     -2580     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvditt pvditt requested a review from hamersaw April 3, 2024 18:09
Signed-off-by: Paul Dittamo <[email protected]>
@pvditt pvditt marked this pull request as ready for review April 4, 2024 01:27
@pvditt pvditt requested review from neverett and ppiegaze as code owners April 4, 2024 01:27
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Apr 4, 2024
Copy link
Contributor

@hamersaw hamersaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, should just need to make generate to create pflags. do we want to go ahead and add jitter configuration to the other places for uniformity?

Signed-off-by: Paul Dittamo <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
@pvditt pvditt merged commit 0095165 into master Apr 18, 2024
46 checks passed
@pvditt pvditt deleted the feature/add-retries-admin-sink branch April 18, 2024 18:53
pmahindrakar-oss pushed a commit that referenced this pull request May 1, 2024
* [Feature] add retries and backoffs for propeller sending events to admin (#5166)

* add retries and backoffs for propeller sending events to admin

Signed-off-by: Paul Dittamo <[email protected]>

* update docs

Signed-off-by: Paul Dittamo <[email protected]>

* update retry types

Signed-off-by: Paul Dittamo <[email protected]>

* support expontential backoffs w/ jitter for catalog connection

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>

* propeller config generate

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Co-authored-by: Paul Dittamo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants