-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] add retries and backoffs for propeller sending events to admin #5166
Conversation
Signed-off-by: Paul Dittamo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5166 +/- ##
===========================================
- Coverage 59.10% 17.79% -41.31%
===========================================
Files 645 3 -642
Lines 55574 399 -55175
===========================================
- Hits 32846 71 -32775
+ Misses 20135 315 -19820
+ Partials 2593 13 -2580
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Dittamo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, should just need to make generate
to create pflags. do we want to go ahead and add jitter configuration to the other places for uniformity?
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
* [Feature] add retries and backoffs for propeller sending events to admin (#5166) * add retries and backoffs for propeller sending events to admin Signed-off-by: Paul Dittamo <[email protected]> * update docs Signed-off-by: Paul Dittamo <[email protected]> * update retry types Signed-off-by: Paul Dittamo <[email protected]> * support expontential backoffs w/ jitter for catalog connection Signed-off-by: Paul Dittamo <[email protected]> --------- Signed-off-by: Paul Dittamo <[email protected]> * propeller config generate Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Paul Dittamo <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Paul Dittamo <[email protected]>
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
Propeller does not have retries or backoffs for the eventsink adminclient (but does for datacatalog and cacheservice). Instead on failure it will consume a system retry and retry (near immediately) to process the workflow, continuing to hammer admin.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link