docs: add missing key in auth guide #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Signed-off-by: Julian Einhaus <[email protected]>
…zation guide Signed-off-by: Julian Einhaus <[email protected]>
Jeinhaus
force-pushed
the
docs/add-missing-key-in-auth-guid
branch
from
33b5eac to
d353c64
Compare
davidmirror-ops
approved these changes
Apr 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5169 +/- ##
=======================================
Coverage 59.11% 59.11%
=======================================
Files 645 645
Lines 55574 55574
=======================================
Hits 32852 32852
Misses 20129 20129
Partials 2593 2593
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For the authentication setup the guide was ok I think. But I still haven't gotten authorization working with Keycloak. For now, we used the internal authorization server. So I'm pretty sure there are parts missing, but I can't tell you what since I haven't figured it out 🙈 . |
|
Congrats on merging your first pull request! 🎉 |
Jeinhaus
added a commit
to Jeinhaus/flyte
that referenced
this pull request
Apr 8, 2024
* docs(flyte-core): add missing key `adminServer` in authentication guide Signed-off-by: Julian Einhaus <[email protected]> * docs(flyte-core): fix indentation for flyte-core with AzureAD authorization guide Signed-off-by: Julian Einhaus <[email protected]> --------- Signed-off-by: Julian Einhaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The authentication and authorization guides for
flyte-coreare slightly wrong and led to some confusion on our side.What changes were proposed in this pull request?
This PR should fix missing keys and improve some formatting for the AzureAD guide.
Docs link