Stop admin launcher copying shard key from parent workflow #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>
Tom-Newton
force-pushed
the
tomnewton/admin_launcher_does_not_icopy_shard_key_from_parent/GH-5173
branch
from
ebee557 to
5d44e42
Compare
dosubot
bot
added
size:S
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5174 +/- ##
=======================================
Coverage 59.11% 59.11%
=======================================
Files 645 645
Lines 55574 55579 +5
=======================================
+ Hits 32852 32857 +5
Misses 20129 20129
Partials 2593 2593
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Apr 4, 2024
Jeinhaus
pushed a commit
to Jeinhaus/flyte
that referenced
this pull request
Apr 8, 2024
…5174) * Remove shard key in admin-launcher Signed-off-by: Thomas Newton <[email protected]> * Don't mutate existing state Signed-off-by: Thomas Newton <[email protected]> * Don't mutate state Signed-off-by: Thomas Newton <[email protected]> * Add a test Signed-off-by: Thomas Newton <[email protected]> --------- Signed-off-by: Thomas Newton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes: #5173
Why are the changes needed?
For more uniform distribution of workflows across fltyepropeller shards.
What changes were proposed in this pull request?
Specifically delete the
shard-keylabel but copy all the other labels from parent to child as before.How was this patch tested?
Added a unit test
I've been using it in production.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link