-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ray): Remove initContainers #5178
feat(ray): Remove initContainers #5178
Conversation
Resolves: flyteorg#5165 Signed-off-by: Chi-Sheng Liu <[email protected]>
@ByronHsu Can you help me review this PR? Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5178 +/- ##
==========================================
- Coverage 59.06% 59.05% -0.02%
==========================================
Files 646 646
Lines 55714 55701 -13
==========================================
- Hits 32910 32894 -16
- Misses 20208 20210 +2
- Partials 2596 2597 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks good. Have you run e2e test? Can you attach a successful run screenshot? |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Tracking issue
Resolves: #5165
Why are the changes needed?
The init container in flyte is no longer needed because the latest kuberay already has init container.
What changes were proposed in this pull request?
Remove the init container in flyte.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link