Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ray): Remove initContainers #5178

Conversation

MortalHappiness
Copy link
Member

Tracking issue

Resolves: #5165

Why are the changes needed?

The init container in flyte is no longer needed because the latest kuberay already has init container.

What changes were proposed in this pull request?

Remove the init container in flyte.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Resolves: flyteorg#5165
Signed-off-by: Chi-Sheng Liu <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Apr 4, 2024
@MortalHappiness
Copy link
Member Author

@ByronHsu Can you help me review this PR? Thanks.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.05%. Comparing base (f1c2231) to head (f6b6ecb).
Report is 18 commits behind head on master.

❗ Current head f6b6ecb differs from pull request most recent head ea174bf. Consider uploading reports for the commit ea174bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
- Coverage   59.06%   59.05%   -0.02%     
==========================================
  Files         646      646              
  Lines       55714    55701      -13     
==========================================
- Hits        32910    32894      -16     
- Misses      20208    20210       +2     
- Partials     2596     2597       +1     
Flag Coverage Δ
unittests 59.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ByronHsu
Copy link
Contributor

ByronHsu commented Apr 4, 2024

Looks good. Have you run e2e test? Can you attach a successful run screenshot?

@MortalHappiness
Copy link
Member Author

Looks good. Have you run e2e test? Can you attach a successful run screenshot?

image

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
@pingsutw pingsutw merged commit c7d1463 into flyteorg:master Apr 12, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Remove init container in ray because the latest kuberay already has init container
4 participants