-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize flyteidl Rust crate #5219
Merged
pingsutw
merged 4 commits into
flyteorg:master
from
austin362667:austin362667/flyteidl/rs
Apr 21, 2024
Merged
Finalize flyteidl Rust crate #5219
pingsutw
merged 4 commits into
flyteorg:master
from
austin362667:austin362667/flyteidl/rs
Apr 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
enhancement
New feature or request
labels
Apr 11, 2024
Signed-off-by: Austin Liu <[email protected]>
Will we build a rust client crate here? |
I don't think so for now. |
For example, to add a local dependency, you can do the following: Or add a dependency via |
pingsutw
previously approved these changes
Apr 15, 2024
Signed-off-by: Austin Liu <[email protected]>
pingsutw
approved these changes
Apr 16, 2024
pingsutw
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flytekit#2328
Why are the changes needed?
Expose Flyteidl Rust crate based on #5187
It can be added as a local dependency by Flyekit.
What changes were proposed in this pull request?
Initialize
cargo.toml
andlib.rs
.How was this patch tested?
Setup process
cargo b --release
Screenshots
Check all the applicable boxes
Related PRs
Docs link