Clear finalizer on abort for arrays #5221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Raposo <[email protected]>
dosubot
bot
added
the
size:M
|
We're still investigating this, we found some odd behaviour when an execution is terminated too fast. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5222
Why are the changes needed?
This adds the ability for propeller to remove finalizer when the Phase of the plugin execution is aborted. This somewhat mimics what was done in the Happy path phase with small differences.
Note: We've tested this PR in our test cluster and noticed some slowness in cleaning the pods but they eventually are cleaned up (about 500 pods) not sure if expected or not and can test this further.
What changes were proposed in this pull request?
Before the deletion of pod we remove the finalizer of the aborted MapTask if set
How was this patch tested?
In our test cluster, no unit tests added since there's no unit tests for
subtask.goSetup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link