Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammatical error in workflow lifecycle docs #5227

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

Sovietaced
Copy link
Contributor

Advice is a noun while advise is a verb

Copy link

welcome bot commented Apr 11, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 12, 2024
@Sovietaced
Copy link
Contributor Author

Not sure if the doc ci is unstable or I have introduced some issue. And I don't seem to be able to rerun the CI.

@neverett
Copy link
Contributor

@Sovietaced can you merge master into your branch and push again? This PR should have fixed the build error you're running into.

@pingsutw pingsutw merged commit ed23620 into flyteorg:master Apr 15, 2024
46 checks passed
Copy link

welcome bot commented Apr 15, 2024

Congrats on merging your first pull request! 🎉

@Sovietaced Sovietaced deleted the patch-1 branch April 15, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants