Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional port configuration for flyte services #5233

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Apr 15, 2024

Tracking issue

NA

Why are the changes needed?

Users may want to expose additional ports through k8s services for Flyte components.

What changes were proposed in this pull request?

This PR adds configuration for exposing additional ports through helm.

How was this patch tested?

Updated the values file to include a port in the additional port and generated yaml files using:

helm template -n flyte --create-namespace flyte ~/Development/flyte/charts/flyte-core --values ~/Development/flyte/charts/flyte-core/values.yaml --debug > flyte.yaml

verified that the services included an additional port.

Setup process

NA

Screenshots

NA

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw marked this pull request as ready for review April 15, 2024 14:32
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Apr 15, 2024
Signed-off-by: Daniel Rammer <[email protected]>
Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2024
@hamersaw hamersaw merged commit 2ba277f into master Apr 15, 2024
51 checks passed
@hamersaw hamersaw deleted the feature/additional-service-ports branch April 15, 2024 16:39
pmahindrakar-oss pushed a commit that referenced this pull request May 1, 2024
* added additional port configuration for flyte services



* removed unecessary extra end



* fixed datacatalog indentation



---------

Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants