[Docs] add validation file tpye #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add instructions for enabling type validation with `python-magic` package - Note that type validation is currently only supported on `Mac OS` and `Linux` platforms Signed-off-by: jason.lai <[email protected]>
- Update the error message for invalid input - Remove unnecessary console.log statements Signed-off-by: jason.lai <[email protected]>
- Update the link to `python-magic` package in the user guide - Add installation instructions for `libmagic` on OSX - Add installation instructions for `libmagic1` on Debian/Ubuntu Signed-off-by: jason.lai <[email protected]>
- Update the markdown code blocks to include backticks around the OS names Signed-off-by: jason.lai <[email protected]>
dosubot
bot
added
size:S
pingsutw
previously approved these changes
Apr 21, 2024
- Update code blocks to use `eval-rst` for better rendering - Remove outdated installation instructions for `libmagic` on OSX and Debian/Ubuntu Signed-off-by: jason.lai <[email protected]>
neverett
approved these changes
Apr 22, 2024
pingsutw
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
add descrption for verification file type
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytekit#1893
Docs link