Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling parallelism controls on arraynode #5284

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

hamersaw
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

missed in https://github.com/unionai/flyte/pull/229

What changes were proposed in this pull request?

Enabling parallelism application for ArrayNode from node executor.

How was this patch tested?

Local testing.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.82%. Comparing base (8eb7b0d) to head (22edde7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5284       +/-   ##
===========================================
- Coverage   76.78%   56.82%   -19.96%     
===========================================
  Files          18       34       +16     
  Lines        1516     2154      +638     
===========================================
+ Hits         1164     1224       +60     
- Misses        288      837      +549     
- Partials       64       93       +29     
Flag Coverage Δ
unittests 56.82% <ø> (-19.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw hamersaw enabled auto-merge (squash) April 24, 2024 20:26
@hamersaw hamersaw merged commit 876999c into master Apr 24, 2024
46 of 48 checks passed
@hamersaw hamersaw deleted the bug/arraynode-parallelism branch April 24, 2024 20:29
pmahindrakar-oss pushed a commit that referenced this pull request May 1, 2024
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants