Remove upper bound on flyteidl's protobuf dependency #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Elliot <[email protected]> Signed-off-by: Mark Elliot <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
mark-thm
changed the title
pingsutw
approved these changes
Apr 30, 2024
| @@ -13,7 +13,7 @@ requires-python = ">=3.8,<3.13" | |||
| dependencies = [ | |||
| 'googleapis-common-protos', | |||
| 'protoc-gen-openapiv2', | |||
| 'protobuf>=4.21.1,<5.0.0', | |||
| 'protobuf>=4.21.1', | |||
There was a problem hiding this comment.
I think it's fine to remove the upper bound. cc @eapolinario @wild-endeavor any concerns?
eapolinario
approved these changes
Apr 30, 2024
|
Congrats on merging your first pull request! 🎉 |
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
Signed-off-by: Mark Elliot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
flyteidl claims Python 3.12 support, as does flytekit, but protobuf<5.0.0 only supports up to Python 3.11.
What changes were proposed in this pull request?
Remove the upper bound on flyteidl's protobuf dependency to enable Python 3.12 support.
How was this patch tested?
Existing/standard CI tests.
Setup process
n/a
Screenshots
n/a
Check all the applicable boxes
Related PRs
n/a
Docs link
n/a