Bring back image build job and be explicit about flyteadmin int tests #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5331 +/- ##
==========================================
+ Coverage 61.10% 62.47% +1.37%
==========================================
Files 794 611 -183
Lines 51213 37478 -13735
==========================================
- Hits 31294 23415 -7879
+ Misses 17038 11935 -5103
+ Partials 2881 2128 -753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
May 7, 2024
eapolinario
deleted the
bring-back-docker-image-builds-and-separate-flyteadmin-int-tests
branch
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
…flyteorg#5331) Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Let's make sure the job used to build images during releases is exercised at PR time. Also, be explicit about the execution requirements for flyteadmin integration tests.
What changes were proposed in this pull request?
Bring back the
build_docker_imagesjob removed in #5327 and also rename the jobs related to running flyteadmin integration tests.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link