-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idl/json type #5337
base: master
Are you sure you want to change the base?
Idl/json type #5337
Conversation
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5337 +/- ##
==========================================
- Coverage 62.49% 61.10% -1.39%
==========================================
Files 611 794 +183
Lines 37478 51213 +13735
==========================================
+ Hits 23421 31295 +7874
- Misses 11929 17037 +5108
- Partials 2128 2881 +753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -46,6 +46,10 @@ message Binary { | |||
string tag = 2; | |||
} | |||
|
|||
message Json { | |||
string value = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use byte instead here?
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link