Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking pixel to README #5371

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

neverett
Copy link
Contributor

@neverett neverett commented May 15, 2024

Why are the changes needed?

Adds tracking pixel to README per @kumare3 request.

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: nikki everett <[email protected]>
@neverett neverett self-assigned this May 15, 2024
@neverett neverett requested review from EngHabu and ppiegaze May 15, 2024 19:19
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.10%. Comparing base (4dd5f3c) to head (3549003).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5371   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files         794      794           
  Lines       51215    51215           
=======================================
+ Hits        31296    31297    +1     
+ Misses      17038    17037    -1     
  Partials     2881     2881           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit add971e into master May 15, 2024
49 of 50 checks passed
@davidmirror-ops davidmirror-ops deleted the nikki/add-readme-pixel branch May 15, 2024 21:07
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants