Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build flytectl monodocs from monorepo #5374

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

flytectl is now built and released from the monorepo. Time to build the flytectl monodocs from the monorepo.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (add971e) to head (b92efc4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5374      +/-   ##
==========================================
+ Coverage   60.22%   60.23%   +0.01%     
==========================================
  Files         646      646              
  Lines       45664    45664              
==========================================
+ Hits        27499    27505       +6     
+ Misses      15575    15569       -6     
  Partials     2590     2590              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) May 15, 2024 23:19
Copy link
Contributor

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eapolinario eapolinario merged commit 31802c7 into master May 16, 2024
49 of 50 checks passed
@eapolinario eapolinario deleted the eapolinario-patch-2 branch May 16, 2024 14:48
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants