Skip flytectl upgrade tests #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5381 +/- ##
==========================================
+ Coverage 60.22% 61.10% +0.88%
==========================================
Files 646 793 +147
Lines 45664 51156 +5492
==========================================
+ Hits 27499 31257 +3758
- Misses 15575 17027 +1452
- Partials 2590 2872 +282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor
approved these changes
May 17, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* Skip flytectl upgrade tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix lint errors for real this time Signed-off-by: Eduardo Apolinario <[email protected]> * Skip all tests using a TestMain Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
troychiu
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Skip flytectl upgrade tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix lint errors for real this time Signed-off-by: Eduardo Apolinario <[email protected]> * Skip all tests using a TestMain Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Andrew Dye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #5372
Why are the changes needed?
Unit tests in master shouldn't fail, so while we figure out how to fix
flytectl upgradewe should skip those tests.What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link