Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source code renderer section from Decks article #5397

Merged
merged 1 commit into from
May 20, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented May 20, 2024

Why are the changes needed?

Removes reference to source code renderer from Decks doc since it was removed from flytesnacks example code in flyteorg/flytesnacks#1674

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytesnacks#1674

Docs link

TK

Signed-off-by: nikki everett <[email protected]>
@neverett neverett requested a review from eapolinario May 20, 2024 18:23
@neverett neverett self-assigned this May 20, 2024
@neverett neverett requested a review from ppiegaze as a code owner May 20, 2024 18:23
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.06%. Comparing base (1384b32) to head (054622a).
Report is 135 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5397      +/-   ##
==========================================
- Coverage   61.07%   61.06%   -0.02%     
==========================================
  Files         793      793              
  Lines       51210    51210              
==========================================
- Hits        31275    31269       -6     
- Misses      17059    17065       +6     
  Partials     2876     2876              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.86% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.98% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) May 20, 2024 18:41
@eapolinario eapolinario merged commit 16d2b14 into master May 20, 2024
48 of 50 checks passed
@eapolinario eapolinario deleted the nikki/update-example-code-ref branch May 20, 2024 18:42
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants