Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream revert revert auth token fix #5407

Merged
merged 15 commits into from
May 31, 2024

Merge remote-tracking branch 'upstream/master' into upstream-revert-r…

6ac430b
Select commit
Loading
Failed to load commit list.
Merged

Upstream revert revert auth token fix #5407

Merge remote-tracking branch 'upstream/master' into upstream-revert-r…
6ac430b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 31, 2024 in 0s

67.56% (+6.46%) compared to 1e61f4e

View this Pull Request on Codecov

67.56% (+6.46%) compared to 1e61f4e

Details

Codecov Report

Attention: Patch coverage is 34.61538% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 67.56%. Comparing base (1e61f4e) to head (6ac430b).

❗ Current head 6ac430b differs from pull request most recent head 595de20

Please upload reports for the commit 595de20 to get more accurate results.

Files Patch % Lines
flytectl/pkg/pkce/token_cache_keyring.go 6.25% 30 Missing ⚠️
flyteidl/clients/go/admin/auth_interceptor.go 48.27% 10 Missing and 5 partials ⚠️
...admin/tokenorchestrator/base_token_orchestrator.go 55.55% 2 Missing and 2 partials ⚠️
flyteidl/clients/go/admin/token_source_provider.go 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5407      +/-   ##
==========================================
+ Coverage   61.09%   67.56%   +6.46%     
==========================================
  Files         793      199     -594     
  Lines       51169     8643   -42526     
==========================================
- Hits        31264     5840   -25424     
+ Misses      17033     2360   -14673     
+ Partials     2872      443    -2429

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov