Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream revert revert auth token fix #5407

Merged
merged 15 commits into from
May 31, 2024

typo fix

595de20
Select commit
Loading
Failed to load commit list.
Merged

Upstream revert revert auth token fix #5407

typo fix
595de20
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 31, 2024 in 0s

61.07% (-0.03%) compared to 1e61f4e

View this Pull Request on Codecov

61.07% (-0.03%) compared to 1e61f4e

Details

Codecov Report

Attention: Patch coverage is 34.61538% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 61.07%. Comparing base (1e61f4e) to head (595de20).

Files Patch % Lines
flytectl/pkg/pkce/token_cache_keyring.go 6.25% 30 Missing ⚠️
flyteidl/clients/go/admin/auth_interceptor.go 48.27% 10 Missing and 5 partials ⚠️
...admin/tokenorchestrator/base_token_orchestrator.go 55.55% 2 Missing and 2 partials ⚠️
flyteidl/clients/go/admin/token_source_provider.go 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5407      +/-   ##
==========================================
- Coverage   61.09%   61.07%   -0.03%     
==========================================
  Files         793      793              
  Lines       51169    51226      +57     
==========================================
+ Hits        31264    31288      +24     
- Misses      17033    17062      +29     
- Partials     2872     2876       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov