Update the example Flyte agent Dockerfile #5412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
pingsutw
approved these changes
May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5412 +/- ##
==========================================
+ Coverage 61.08% 66.85% +5.76%
==========================================
Files 793 52 -741
Lines 51156 3089 -48067
==========================================
- Hits 31250 2065 -29185
+ Misses 17034 867 -16167
+ Partials 2872 157 -2715
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
May 22, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
May 31, 2024
Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
eapolinario
added a commit
that referenced
this pull request
May 31, 2024
* Revert "Revert "Ensure token is refreshed on Unauthenticated (#5388)" (#5404)" This reverts commit 7d2f0d0. Signed-off-by: pmahindrakar-oss <[email protected]> * Using same mutex for condition variable Signed-off-by: pmahindrakar-oss <[email protected]> * Lock the locker in the wait to adher to cond.Wait() semantics Signed-off-by: pmahindrakar-oss <[email protected]> * comments Signed-off-by: pmahindrakar-oss <[email protected]> * using noop locker as waitlist add is atomic operation Signed-off-by: pmahindrakar-oss <[email protected]> * Replace Azure AD OIDC URL with correct one (#4075) Signed-off-by: Erwin de Haan <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * Update the example Dockerfile to run on k8s (#5412) Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * docs(kubeflow): Fix kubeflow webhook error (#5410) Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * update flytekit version to 1.12.1b2 in monodocs requirements (#5411) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * Add supported task types to agent service config and rename (#5402) Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * update lock file (#5416) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * [monorepo] Fix flytectl install script (#5405) Signed-off-by: pmahindrakar-oss <[email protected]> * bring in changes for flytecl keyring from PR flytectl/pull/488 Signed-off-by: pmahindrakar-oss <[email protected]> * typo fix Signed-off-by: pmahindrakar-oss <[email protected]> --------- Signed-off-by: pmahindrakar-oss <[email protected]> Signed-off-by: Erwin de Haan <[email protected]> Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: Samhita Alla <[email protected]> Co-authored-by: Erwin de Haan <[email protected]> Co-authored-by: Jason Parraga <[email protected]> Co-authored-by: Chi-Sheng Liu <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Jason Parraga <[email protected]>
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* Revert "Revert "Ensure token is refreshed on Unauthenticated (flyteorg#5388)" (flyteorg#5404)" This reverts commit 7d2f0d0. Signed-off-by: pmahindrakar-oss <[email protected]> * Using same mutex for condition variable Signed-off-by: pmahindrakar-oss <[email protected]> * Lock the locker in the wait to adher to cond.Wait() semantics Signed-off-by: pmahindrakar-oss <[email protected]> * comments Signed-off-by: pmahindrakar-oss <[email protected]> * using noop locker as waitlist add is atomic operation Signed-off-by: pmahindrakar-oss <[email protected]> * Replace Azure AD OIDC URL with correct one (flyteorg#4075) Signed-off-by: Erwin de Haan <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * Update the example Dockerfile to run on k8s (flyteorg#5412) Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * docs(kubeflow): Fix kubeflow webhook error (flyteorg#5410) Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * update flytekit version to 1.12.1b2 in monodocs requirements (flyteorg#5411) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * Add supported task types to agent service config and rename (flyteorg#5402) Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * update lock file (flyteorg#5416) Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]> * [monorepo] Fix flytectl install script (flyteorg#5405) Signed-off-by: pmahindrakar-oss <[email protected]> * bring in changes for flytecl keyring from PR flytectl/pull/488 Signed-off-by: pmahindrakar-oss <[email protected]> * typo fix Signed-off-by: pmahindrakar-oss <[email protected]> --------- Signed-off-by: pmahindrakar-oss <[email protected]> Signed-off-by: Erwin de Haan <[email protected]> Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Chi-Sheng Liu <[email protected]> Signed-off-by: Samhita Alla <[email protected]> Co-authored-by: Erwin de Haan <[email protected]> Co-authored-by: Jason Parraga <[email protected]> Co-authored-by: Chi-Sheng Liu <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings the example agent dockerfile up to date with what is used on master such that it will run on k8s without blowing up.
The prometheus-client module is required by the agent code and the health checking service is required for k8s health checking it seems.