Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different git command to match the flyteidl tags #5419

Merged
merged 1 commit into from
May 24, 2024

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

Moving flytectl to the monorepo caused flyteidl build script to match the wrong tags to calculate the next version.

What changes were proposed in this pull request?

Use a specific git command to match only the flyteidl tags.

How was this patch tested?

Ran locally.

Before the fix:

~/repos/flyte/flyteidl master
❯ python -m build 2>/dev/null | grep "Successfully built"
Successfully built flyteidl-0.8.22.dev11+g0583f7743.tar.gz and flyteidl-0.8.22.dev11+g0583f7743-py3-none-any.whl

After the fix:

~/repos/flyte/flyteidl fix-flyteidl-weird-version
❯ python -m build 2>/dev/null | grep "Successfully built"
Successfully built flyteidl-1.12.1.dev38+ga46890bb0.tar.gz and flyteidl-1.12.1.dev38+ga46890bb0-py3-none-any.whl

Notice how flytectl/0.8.21 is the latest git tag in the repo: https://github.com/flyteorg/flyte/releases/tag/flytectl%2Fv0.8.21.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (0583f77) to head (a46890b).
Report is 130 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5419      +/-   ##
==========================================
- Coverage   61.10%   61.09%   -0.01%     
==========================================
  Files         793      793              
  Lines       51156    51156              
==========================================
- Hits        31257    31256       -1     
- Misses      17027    17028       +1     
  Partials     2872     2872              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasjpfan thomasjpfan merged commit 5f9abaf into master May 24, 2024
48 of 50 checks passed
@thomasjpfan thomasjpfan deleted the fix-flyteidl-weird-version branch May 24, 2024 13:01
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants