Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that jq is now required to install flytectl via the script #5440

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

After we moved flytectl to the monorepo we require jq to be installed to be able to filter out unwanted Flyte releases.

What changes were proposed in this pull request?

This PR just adds a warning to the "Other Operating Systems" tab in the docs.

How was this patch tested?

I tried generating the docs locally, but failed.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.11%. Comparing base (715496a) to head (877fb17).
Report is 136 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5440   +/-   ##
=======================================
  Coverage   61.11%   61.11%           
=======================================
  Files         793      793           
  Lines       51169    51169           
=======================================
  Hits        31270    31270           
  Misses      17027    17027           
  Partials     2872     2872           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.34% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) May 31, 2024 22:04
@eapolinario eapolinario merged commit 9ffc54f into master Jun 3, 2024
53 checks passed
@eapolinario eapolinario deleted the mention-jq-as-a-req-in-flytectl branch June 3, 2024 04:41
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants