Include group in apiVersion in plugin_collector #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor McGuire <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
trevormcguire
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5457 +/- ##
==========================================
- Coverage 61.07% 60.60% -0.48%
==========================================
Files 793 775 -18
Lines 51226 49904 -1322
==========================================
- Hits 31288 30242 -1046
+ Misses 17062 16854 -208
+ Partials 2876 2808 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Cc @andrewwdye |
hamersaw
approved these changes
Jun 10, 2024
|
@trevormcguire thanks for the PR! |
|
Congrats on merging your first pull request! 🎉 |
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Trevor McGuire <[email protected]>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Trevor McGuire <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5429
Why are the changes needed?
Correctly sets apiVersion to include group; fixes the
failed to list objects for ...warning incollectWhat changes were proposed in this pull request?
ResourceLevelMonitorincludesschema.GroupVersionKind(gvk). The changes here correctly set theapiVersionincollectby utilizinggvk.GroupVersion().String(), which puts "group" and "version" into a single "group/version" stringhttps://github.com/kubernetes/apimachinery/blob/703232ea6da48aed7ac22260dabc6eac01aab896/pkg/runtime/schema/group_version.go#L178-L182
How was this patch tested?
Built flytepropeller image with this change, deployed, ensured resources were correctly listed and ensured the aforementioned warning didn't appear.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link