Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mmcloud plugin #5468

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Jun 11, 2024

Why are the changes needed?

The MMCloud plugin example was removed from flytesnacks, so should be removed from flyte docs.

What changes were proposed in this pull request?

Removed MMCloud plugin docs and added redirects to MMCloud agent docs.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytesnacks#1696

Docs link

TK

Signed-off-by: nikki everett <[email protected]>
@neverett neverett requested a review from davidmirror-ops June 11, 2024 18:29
@neverett neverett self-assigned this Jun 11, 2024
@neverett neverett requested a review from ppiegaze as a code owner June 11, 2024 18:29
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.97%. Comparing base (15e321b) to head (ff6c569).
Report is 138 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5468      +/-   ##
==========================================
- Coverage   60.98%   60.97%   -0.02%     
==========================================
  Files         793      793              
  Lines       51313    51313              
==========================================
- Hits        31294    31288       -6     
- Misses      17134    17140       +6     
  Partials     2885     2885              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.62% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.97% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.84% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops enabled auto-merge (squash) June 11, 2024 18:44
@davidmirror-ops davidmirror-ops merged commit bd2f9a8 into master Jun 11, 2024
48 of 50 checks passed
@davidmirror-ops davidmirror-ops deleted the nikki/docs/remove-mmcloud-plugin branch June 11, 2024 18:51
eapolinario pushed a commit that referenced this pull request Jun 11, 2024
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants