reimplement functions in go-mouff-update, use ghreposervice

[novahow]

Tracking issue

closes #5372

Why are the changes needed?

flytectl upgrade is not working after monorepo integration

What changes were proposed in this pull request?

Cloned the code from the original external package https://github.com/mouuff/go-rocket-update/blob/v1.5.4/pkg/provider/provider_github.go , and made modifications to fit our needs

How was this patch tested?

make test_unit

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[codecov]

Codecov Report

Attention: Patch coverage is 21.97802% with 71 lines in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (5b0d787) to head (da3a344).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
flytectl/pkg/github/provider.go	20.22%	68 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5470      +/-   ##
==========================================
- Coverage   60.97%   60.93%   -0.05%     
==========================================
  Files         794      796       +2     
  Lines       51488    51640     +152     
==========================================
+ Hits        31397    31465      +68     
- Misses      17199    17270      +71     
- Partials     2892     2905      +13     

Flag	Coverage Δ
unittests-datacatalog	69.31% <ø> (ø)
unittests-flyteadmin	58.69% <ø> (ø)
unittests-flytecopilot	17.79% <ø> (ø)
unittests-flytectl	67.41% <21.97%> (-0.63%)	⬇️
unittests-flyteidl	79.04% <ø> (ø)
unittests-flyteplugins	61.85% <ø> (ø)
unittests-flytepropeller	57.29% <ø> (ø)
unittests-flytestdlib	65.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

Thanks for your PR. Can you fix the lint errors?

[eapolinario]

Do we really have to provide real implementations of all these functions in provider.go?

Also, can you add a few unit tests?

[eapolinario]

remove.

[novahow]

Do we really have to provide real implementations of all these functions in provider.go?

Also, can you add a few unit tests?

Currently I haven't came up with a way to better utilize the original provider, since embedding the original provider didn't seem feasible

[eapolinario]

Thanks for adding the tests.

It's looking good. Just a few comments.

[eapolinario]

Thank you for this change. We're getting there.

Can you re-enable upgrade_test.go tests by removing this TestMain?

Also, in order to fix the version subcommand we have to make a slight change to how we pipe the latest flytectl version in flytectl makefile. Change GIT_VERSION to GIT_VERSION := $(shell git describe --dirty --tags --long --match flytectl/* --first-parent | sed 's/^flytectl\///')

[eapolinario]

Some tests in version_test.go were not calling TearDown (basically another instance of #5325). Fixed in da3a344.

[eapolinario]

Thank you for all your work on this!