Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace uctl with flytectl in OSS docs #5501

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Jun 21, 2024

Why are the changes needed?

OSS docs mention uctl (cli for Union.ai) instead of flytectl in two locations.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

Signed-off-by: Fabio Grätz <[email protected]>
@fg91 fg91 changed the title Fix: replace with in OSS docs Fix: replace uctl with flytectl in OSS docs Jun 21, 2024
@fg91 fg91 requested a review from neverett June 21, 2024 21:26
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.00%. Comparing base (4cb1473) to head (0718301).
Report is 131 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5501      +/-   ##
==========================================
- Coverage   61.01%   61.00%   -0.01%     
==========================================
  Files         794      794              
  Lines       51441    51441              
==========================================
- Hits        31385    31382       -3     
- Misses      17164    17166       +2     
- Partials     2892     2893       +1     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.71% <ø> (-0.03%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.03% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.30% <ø> (ø)
unittests-flytestdlib 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@davidmirror-ops davidmirror-ops merged commit f54b74e into master Jun 21, 2024
53 checks passed
@davidmirror-ops davidmirror-ops deleted the fg91/fix/replace-uctl-w-flytectl branch June 21, 2024 22:38
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Signed-off-by: Fabio Grätz <[email protected]>
Co-authored-by: Fabio Grätz <[email protected]>
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Fabio Grätz <[email protected]>
Co-authored-by: Fabio Grätz <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants