-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLP and sampling to otelutils #5504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
force-pushed
the
andrew/otelutils-otlp
branch
from
June 22, 2024 22:18
9f77223
to
1b5eb0f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5504 +/- ##
==========================================
- Coverage 61.01% 60.99% -0.02%
==========================================
Files 794 794
Lines 51441 51470 +29
==========================================
+ Hits 31385 31395 +10
- Misses 17164 17183 +19
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewwdye
commented
Jun 22, 2024
Signed-off-by: Andrew Dye <[email protected]>
Sovietaced
approved these changes
Jun 24, 2024
hamersaw
approved these changes
Jun 25, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
* Add OTLP and sampling to otelutils Signed-off-by: Andrew Dye <[email protected]> * Add RegisterTracerProviderWithContext Signed-off-by: Andrew Dye <[email protected]> --------- Signed-off-by: Andrew Dye <[email protected]>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
* Add OTLP and sampling to otelutils Signed-off-by: Andrew Dye <[email protected]> * Add RegisterTracerProviderWithContext Signed-off-by: Andrew Dye <[email protected]> --------- Signed-off-by: Andrew Dye <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This changes adds support for OLTP and sampling to the otelutils tracer provider abstraction.
Adds support for OLTP. This is the recommended replacement for the deprecated jaeger exporter.
OLTP supports grpc and http, which are added as separate exporter types and configs.
Adds initial sampling support to the top level open telemetry config. Defaults to parent sampler
always
, but also adds a config for TraceIdRatioBased. See these docs for behavior of parent sampler.How was this patch tested?
Ran local sandbox with local jaeger all-in-one and verified
Flyte config
Jaeger