Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ImageSpec experiment warning #5510

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

ppiegaze
Copy link
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@ppiegaze ppiegaze requested a review from neverett as a code owner June 25, 2024 09:37
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.01%. Comparing base (5cfd004) to head (aa5f4a2).
Report is 203 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5510      +/-   ##
==========================================
- Coverage   61.10%   61.01%   -0.09%     
==========================================
  Files         794      794              
  Lines       51213    51444     +231     
==========================================
+ Hits        31295    31390      +95     
- Misses      17037    17162     +125     
- Partials     2881     2892      +11     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (-0.18%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.09% <ø> (-0.21%) ⬇️
unittests-flyteidl 79.04% <ø> (-0.26%) ⬇️
unittests-flyteplugins 61.85% <ø> (-0.10%) ⬇️
unittests-flytepropeller 57.30% <ø> (-0.03%) ⬇️
unittests-flytestdlib 65.82% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit d5744da into master Jun 25, 2024
48 of 50 checks passed
@davidmirror-ops davidmirror-ops deleted the peeter/remove-imagespec-experiment-warning branch June 25, 2024 11:00
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Peeter Piegaze <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants