Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream/node event update #5528

Merged
merged 2 commits into from
Jul 2, 2024

fix conflicts

f6f5f95
Select commit
Loading
Failed to load commit list.
Merged

Upstream/node event update #5528

fix conflicts
f6f5f95
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 1, 2024 in 0s

60.97% (-0.01%) compared to 5b0d787

View this Pull Request on Codecov

60.97% (-0.01%) compared to 5b0d787

Details

Codecov Report

Attention: Patch coverage is 59.75610% with 33 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (5b0d787) to head (f6f5f95).

Files Patch % Lines
...lytepropeller/pkg/controller/nodes/common/utils.go 16.66% 15 Missing ⚠️
flytepropeller/pkg/controller/nodes/executor.go 55.55% 7 Missing and 1 partial ⚠️
...ler/pkg/apis/flyteworkflow/v1alpha1/subworkflow.go 0.00% 6 Missing ⚠️
...propeller/pkg/apis/flyteworkflow/v1alpha1/nodes.go 60.00% 2 Missing ⚠️
...eller/pkg/controller/nodes/array/event_recorder.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5528      +/-   ##
==========================================
- Coverage   60.97%   60.97%   -0.01%     
==========================================
  Files         794      794              
  Lines       51488    51537      +49     
==========================================
+ Hits        31397    31426      +29     
- Misses      17199    17217      +18     
- Partials     2892     2894       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov