Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON IDL #5542

Closed
wants to merge 42 commits into from

Create Execution Success, need to implement get Execution

c7c82ac
Select commit
Loading
Failed to load commit list.
Closed

JSON IDL #5542

Create Execution Success, need to implement get Execution
c7c82ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 8, 2024 in 1s

28.18% (-8.00%) compared to 0a441a9

View this Pull Request on Codecov

28.18% (-8.00%) compared to 0a441a9

Details

Codecov Report

Attention: Patch coverage is 8.76289% with 177 lines in your changes missing coverage. Please review.

Project coverage is 28.18%. Comparing base (0a441a9) to head (c7c82ac).
Report is 2 commits behind head on master.

Files Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 4.90% 97 Missing ⚠️
...opeller/pkg/controller/nodes/attr_path_resolver.go 5.08% 54 Missing and 2 partials ⚠️
flyteidl/clients/go/coreutils/literals.go 25.92% 19 Missing and 1 partial ⚠️
flytepropeller/pkg/compiler/validators/typing.go 0.00% 1 Missing and 1 partial ⚠️
flytepropeller/pkg/compiler/validators/utils.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0a441a9) and HEAD (c7c82ac). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (0a441a9) HEAD (c7c82ac)
unittests-flytecopilot 1 0
unittests-flyteadmin 1 0
unittests-flyteplugins 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5542      +/-   ##
==========================================
- Coverage   36.17%   28.18%   -8.00%     
==========================================
  Files        1302      782     -520     
  Lines      109417    75398   -34019     
==========================================
- Hits        39586    21251   -18335     
+ Misses      65695    51936   -13759     
+ Partials     4136     2211    -1925

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov