Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON IDL #5542

Closed
wants to merge 42 commits into from

lint

77ea3ed
Select commit
Loading
Failed to load commit list.
Closed

JSON IDL #5542

lint
77ea3ed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2024 in 1s

36.22% (+0.04%) compared to 7136919

View this Pull Request on Codecov

36.22% (+0.04%) compared to 7136919

Details

Codecov Report

Attention: Patch coverage is 50.47170% with 105 lines in your changes missing coverage. Please review.

Project coverage is 36.22%. Comparing base (7136919) to head (77ea3ed).

Files Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 10.78% 91 Missing ⚠️
...opeller/pkg/controller/nodes/attr_path_resolver.go 87.17% 5 Missing and 5 partials ⚠️
flyteidl/clients/go/coreutils/literals.go 84.61% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5542      +/-   ##
==========================================
+ Coverage   36.18%   36.22%   +0.04%     
==========================================
  Files        1302     1302              
  Lines      109614   109748     +134     
==========================================
+ Hits        39660    39757      +97     
- Misses      65809    65839      +30     
- Partials     4145     4152       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov